Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node 20 issue on GHA CI #47

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix node 20 issue on GHA CI #47

wants to merge 7 commits into from

Conversation

Flamefire
Copy link

No description provided.

@joaquintides
Copy link
Member

Hi @Flamefire, thanks for your contribution. Tests still fail for these jobs:

Any idea what's going on?

@Flamefire
Copy link
Author

Some containers that don't need to be used. Reformatted to verify against the boost-ci template

@pdimov
Copy link
Member

pdimov commented Jan 27, 2025

Why are you setting toolset to the wrong value (toolset: clang++-3.9 instead of toolset: clang-3.9), and then patching it back in the script?

@Flamefire
Copy link
Author

Flamefire commented Feb 2, 2025 •
edited
Loading

Why are you setting toolset to the wrong value (toolset: clang++-3.9 instead of toolset: clang-3.9), and then patching it back in the script?

Not really required in this repo indeed. That was from a RegEx replacement to ensure the correct compiler is used. IIRC I temporarily used matrix.toolset as the compiler in the user config but then decided against it.
Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flamefire @joaquintides @pdimov