Fix unnecessary GitHub Actions version specificity, update old actions, and update to modern GitHub Pages deployment #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening this PR as a draft because I was unable to verify the proper operation of the
docsandtestworkflows. This appears to be due to unrelated to these changes, but I wanted to note the issue. (At a glance, some of the problems related to #31 are a likely culprit.)This PR can probably be safely merged as-is (the affected workflows are only manually run) and these issues can be resolved later, but the GitHub Pages deployment source should probably not be updated until the
docsworkflow is working again.Before merging this PR: Go to the GitHub Pages settings for this repo and change the build/deployment source to "GitHub Actions".(This is necessary, but see note above.)This PR removes unnecessary version specificity for actions used in GitHub Actions workflows in this repository. This reflects best practices and avoids upcoming issues with
actions/setup-dotnet, see this issue for details.While I was at it I migrated the docs workflow to use the modern method for GitHub Pages deployment, and updated other actions as appropriate.