Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use bonitasoft/actions pr-title-conventional-commits #478

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Nov 18, 2022

This action better conforms to Conventional Commits and provides guidelines to help to fix wrong PR titles.

covers #422

This action better conforms to Conventional Commits and provides guidelines to help to fix wrong PR
titles.
@tbouffard tbouffard changed the title ci2: use bonitasoft/actions pr-title-conventional-commits ci23: use bonitasoft/actions pr-title-conventional-commits Nov 18, 2022
@tbouffard
Copy link
Member Author

tbouffard commented Nov 18, 2022

✔️ title checked on edit and reopen with the "pull_request" event

ℹ️ It is not possible to test the "pull_request_target" event in this PR directly: the workflow must be merged to the target branch first.
With "pull_request_target" the workflow definition in the master branch is used, not the one of the PR This is the purpose of this event: use the code of the target branch to run the workflow, and then trust this code as the opposite of the code in a PR.
Tested here

Using pull_request_target allow to create the comment, even if the PR is created from a forked repository. This is not very useful in this repository as we don't have a lot of external contributions. But this will be more important for the bonita-doc repository for instance.

@tbouffard tbouffard closed this Nov 18, 2022
@bonitasoft bonitasoft deleted a comment from github-actions bot Nov 18, 2022
@tbouffard tbouffard reopened this Nov 18, 2022
@bonitasoft bonitasoft deleted a comment from github-actions bot Nov 18, 2022
@tbouffard tbouffard changed the title ci23: use bonitasoft/actions pr-title-conventional-commits ci2: use bonitasoft/actions pr-title-conventional-commits Nov 18, 2022
@tbouffard tbouffard changed the title ci2: use bonitasoft/actions pr-title-conventional-commits ci: use bonitasoft/actions pr-title-conventional-commits Nov 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tbouffard tbouffard marked this pull request as ready for review November 18, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants