Update to Cloud 2.0 and adapt to upstream changes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BT (calcastor/mame) <[email protected]>
calcastor
changed the title
Signed-off-by: BT (calcastor/mame) <[email protected]>
|
This now also makes changes to adapt to potentially running on modern Minecraft. We only register KnockbackManager when using SportPaper to at least attempt to load, while only calling methods and otherwise available from the intersect jar now used in PGM with the exception of KnockbackManager and BoltKnockback, given their explicit SportPaper dependency. For this reason we also don't change to depending on the intersect jar. |
Signed-off-by: BT (calcastor/mame) <[email protected]>
Pablete1234
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP update to Cloud 2.0, depends on PGMDev/PGM#1319 and PGMDev/Events#33.
Currently untested beyond building, removes confirmation manager like the above two PRs.