-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for ipywidgets>=8 #69
Conversation
philippjfr
commented
Nov 18, 2022
•
edited
Loading
edited
- Fixes Required updates for ipywidgets 8.0 #10
- Fixes Wrong widget protocol version #32
- Fixes IpyCanvas raising errors #44
@mattpap Could you review and release version 1.3 when you get a chance? We can then follow up with another PR for bokeh 3.0 compatibility. |
Might need some more testing. |
f8c08e8
to
b360336
Compare
b360336
to
9f2a1dd
Compare
@philippjfr, do you intend any further changes to this PR, or can I proceed with merging and releasing a new version? |
Let's proceed. Seemed to work well for me. |
The Python side of this still needs updating. With ipywidgets 8.0.2 I'm getting:
I already published npm and pip ipywidgets_bokeh 1.3.0 before realizing this. |
Also, do we expect |
Or perhaps this is the issue with ipykernel's |
All packages are published now. |
Damn, taking a look now. As far as I could tell it was working with both 7.x and 8.x. |
So those errors are coming from ipykernel 6.18 which was released yesterday and split out Comm and CommManager into a separate package and changed the baseclasses (removing |
@philippjfr, I removed the defunct version like this |
Perfect, thanks! |