Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDB Syncer version annotation updated to latest & yt-dlp update #327

Closed
wants to merge 3 commits into from

Conversation

Baklap4
Copy link
Contributor

@Baklap4 Baklap4 commented Dec 29, 2024

Changes

PS C:\repos\usdb_syncer> poetry install
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: usdb_syncer (0.7.0)
# After changing
PS C:\repos\usdb_syncer> poetry install
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: usdb_syncer (0.9.0)

Version wasn't updated within the pyproject.toml which leads local development show 0.7.0 in logs while we're already on 0.9.0
@Baklap4
Copy link
Contributor Author

Baklap4 commented Dec 29, 2024

Not quite sure why the pipeline is failing.. :o it's cause of the GH runner updates.... we migrated from 2204 to 2404 unknowingly actions/runner-images#10636

Latest release has fixed a bug regarding signatures
@Baklap4 Baklap4 changed the title USDB Syncer version annotation updated to latest USDB Syncer version annotation updated to latest & yt-dlp update Jan 1, 2025
@RumovZ
Copy link
Collaborator

RumovZ commented Jan 12, 2025

I wasn't aware we have a version attribute in pyproject.toml. That's an issue, because we release by pushing a version tag, and we should only have a single source of truth for the current version number.
Maybe we should use something like setuptools_scm.

@Baklap4
Copy link
Contributor Author

Baklap4 commented Jan 13, 2025

Hmmm for this pr i could split up the GH runner and yt-dlp update.. so at least those can continue on as the pipeline is currently broken

@bohning
Copy link
Owner

bohning commented Jan 14, 2025

Maybe we should use something like setuptools_scm.

I think I found a potentially simpler solution using poetry-dynamic-versioning, see #329.

@bohning bohning mentioned this pull request Jan 14, 2025
@bohning bohning closed this Jan 14, 2025
@Baklap4 Baklap4 deleted the patch-1 branch January 15, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants