Skip to content

Commit

Permalink
bump cifkit to 1.0.0 in requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
bobleesj committed Jul 5, 2024
1 parent 6ab3fc4 commit 2939226
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 18 deletions.
11 changes: 8 additions & 3 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
cifkit-0.32 (2024-07-04)
## [0.32] - 2024-07-04

* Fixed https://github.com/bobleesj/cifkit/issues/7: Remove duplicate connected points in connections
* Added issue and pull request templates
### Added

- Issue and pull request templates.

### Fixed

- Duplicate connected points in connections, see [Issue #7](https://github.com/bobleesj/cifkit/issues/7).
3 changes: 0 additions & 3 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ markdown_extensions:
- pymdownx.superfences
- pymdownx.mark
- attr_list
# - pymdownx.emoji:
# emoji_index: !!python/name:materialx.emoji.twemoji
# emoji_generator: !!python/name:materialx.emoji.to_svg

plugins:
- search
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ build-backend = "setuptools.build_meta"

[project]
name = "cifkit"
version = "0.32"
version = "1.0.0"
description = "Python library for high-throuhgput .cif analysis"
authors = [{name = "Sangjoon Lee", email = "[email protected]"}]
readme = "README.md"
license = {file = "LICENSE"}
keywords = ["cif", "high-throughput", "crystallography"]
keywords = ["cif", "solid-state", "high-throughput", "crystallography"]

[tool.setuptools.packages.find]
where = ["src"]
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ numpy==1.26.4
pyvista==0.43.9
scipy==1.13.1
setuptools==67.8.0
cifkit==0.32
cifkit==1.0.0
19 changes: 10 additions & 9 deletions tests/core/models/test_cif.py
Original file line number Diff line number Diff line change
Expand Up @@ -612,12 +612,13 @@ def print_connected_points(all_labels_connections):
print(f"{label} {dist} {coords_1}, {coords_2}")


@pytest.mark.pyvista
def test_init_atomic_mixing():
file_path = "tests/data/cif/atomic_mixing/261241.cif"
cif = Cif(file_path)
polyhedron_points, vertex_labels = cif.get_polyhedron_labels_by_CN_best_methods(
"CoM1"
)
assert len(polyhedron_points) == 13
assert len(vertex_labels) == 13
# @pytest.mark.now
# def test_init_atomic_mixing_full_occupancy_():
# file_path = "tests/data/cif_CN_init/ErCo2.68In0.32.cif"
# # file_path = "tests/data/cif_CN_init/1956508.cif"
# cif = Cif(file_path)
# cif.compute_connections()
# print_connected_points(cif.connections)
# assert False
# # Error computing polyhedron metrics: index 12 is out of bounds for axis 0 with size 12
# # Problem with Er1

0 comments on commit 2939226

Please sign in to comment.