Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CN bond fraction, System Analysis for binary/ternary, implement cifkit, site-map #22

Merged
merged 35 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
b886f33
Compute coordination numbers with 4 methods
bobleesj Jun 4, 2024
e74ff34
Extract polyhedron geometry info
bobleesj Jun 4, 2024
c34d7a1
Generate polyhedron with labels and colors
bobleesj Jun 4, 2024
4a80166
Determine ring count below and above z of central atom
bobleesj Jun 5, 2024
f0f1259
Implement finding unary cif rad
bobleesj Jun 6, 2024
1db7455
Implement CN categorization for split case
bobleesj Jun 8, 2024
19e1bfd
Find CN15.2 type
bobleesj Jun 9, 2024
f2ecc0a
Compute system analysis sequentially
bobleesj Jun 9, 2024
8730ef5
Implement logic for Cuboctahedron and anticuboctahedron
bobleesj Jun 10, 2024
2213730
Implement nested file processing
bobleesj Jun 12, 2024
85021dd
Fix the binary problem
bobleesj Jun 13, 2024
0726f75
Implement hexagon legend to ternary
bobleesj Jun 13, 2024
a3cf56b
Fix unary
bobleesj Jun 14, 2024
a8fd958
Implement coordination as option 3
bobleesj Jun 18, 2024
1cc36f9
Implement cifkit for site and element pair
bobleesj Jun 19, 2024
3b55cf2
Implement CifEnsemble for site JSON
bobleesj Jun 20, 2024
f29d30b
Fully integrate CifEnsemble to site analysis
bobleesj Jun 20, 2024
ce19236
Implement CN bond fractions
bobleesj Jun 21, 2024
e8b1db4
Implement print progress and nested file count
bobleesj Jun 21, 2024
a26d4eb
Implement all features
bobleesj Jun 22, 2024
22e3db5
Fix the label prolem
bobleesj Jun 22, 2024
890a5af
Plot extra frame on ternary
bobleesj Jun 22, 2024
a15f5e4
Refactor composite image
bobleesj Jun 23, 2024
84d91a1
Refactor prompt
bobleesj Jun 23, 2024
4e1ee27
Add CI integration
bobleesj Jun 24, 2024
ab1e192
Add pyvista
bobleesj Jun 24, 2024
f32ec79
Fix comparision for str lit
bobleesj Jun 24, 2024
98aa2e6
Added Json diff
bobleesj Jun 24, 2024
1f7e015
Fix title of CI
bobleesj Jun 24, 2024
32e9002
Fixed all the ouputs
bobleesj Jun 24, 2024
646bd98
Draft for README.md
bobleesj Jun 25, 2024
401eabc
Add images to README
bobleesj Jun 25, 2024
bfd70f9
Add gif
bobleesj Jun 25, 2024
ff69ec1
Update README.md
bobleesj Jun 25, 2024
f5083ea
Update README.md
bobleesj Jun 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
24 changes: 13 additions & 11 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -24,15 +24,17 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
7 changes: 3 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

title: ""
labels: ""
assignees: ""
---

**Is your feature request related to a problem? Please describe.**
Expand Down
37 changes: 37 additions & 0 deletions .github/workflows/python-run-pytest.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Integration tests

on: [push, pull_request]

jobs:
build-linux:
runs-on: ubuntu-latest
strategy:
max-parallel: 5
matrix:
python-version: ["3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Create virtual environment and install dependencies
run: |
python -m venv venv
source venv/bin/activate
pip install -r requirements.txt

- name: Test with pytest and generate coverage report
run: |
source venv/bin/activate
pip install pytest pytest-cov
python -m pytest --cov=./ --cov-report=xml

- name: Upload coverage reports to Codecov
uses: codecov/[email protected]
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: bobleesj/cif-bond-analyzer
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ nodemon.json
20240531_ternary_binary_combined/
20250519_SA_ternary_binary_CoIn/
20240531_ErCoIn_ternary_binary/
cif-backup-files/

# C extensions
*.so
Expand Down
Loading
Loading