Skip to content

Commit

Permalink
fix: merge generated classes and class prop properly (webstudio-is#4754)
Browse files Browse the repository at this point in the history
Closes webstudio-is#4749

Classes were merged without considering ternaries like this

```js
"cls1" + " " + condition ? "cls2" : ""
```

which made condition part always truthy

Fixed by generating template literal instead of concatenation operator.
  • Loading branch information
TrySound authored Jan 18, 2025
1 parent 94f219c commit 4641b29
Show file tree
Hide file tree
Showing 26 changed files with 178 additions and 205 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions fixtures/ssg/app/__generated__/[another-page]._index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions fixtures/ssg/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 16 additions & 24 deletions fixtures/webstudio-custom-template/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4641b29

Please sign in to comment.