-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 7/ iOS 8 backwards compatability #7
Open
jasonhr13
wants to merge
168
commits into
bobeast:master
Choose a base branch
from
jasonhr13:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apple link.
Update README.md
You need to add android.permission.GET_TASKS. Without this permission, the application crashes when it receives PUSH NOTIFICATION.
Update README.md
Added server script and readme for Amazon Device Messaging.
…from notification. 2. Message is not downloaded when resumed after hitting hoem button.
… config options from sharedPreferences. Also, fixes error message not being shown properly.
…th both android and amazon-fireos
Adding TryCast method improves readability and decreases the code nesting.
It appears that MPNS opens only one channel per application and defines it by name. Sometimes the channeluriupdate is called with delay and it looks like the channel has no Uri. Handle this by adding urichangedcallback js function. Added js error callback to handle errors. Added error to notify the user if they try to open new channel but already have opened one as this is throwing argument exception. Extract the js function execution in separate method as it is reused.
If user want to open new channel they have to have the option to close the current one. Update the error text. Remove the channel field as it is not necessary.
Add API for showing toast notifications, using the system behaviour. Expose interface for users to handle raw and toast notifications by js callbacks. This way they can handle notifications differently than the system
Align correctly tabs.
…vaScript in Cordova Push Notifications Plugin Added logic for Coldstart support. Client JS can parse this flag.
New nodeJS based server script to test amazon ADM push notification services.
Updating sound file section as e.soundname doesn't work on Fire OS. Probably should test it though.
Added in sound change
Update index.html
Update README.md
Updated README.md and Sample code
Fix Cordova link: thanks for updating the link!
remove condition to test if web view is in loading state
Fix xml validation for plugin.xml - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small edit to PushPlugin.m to work with iOS8's new code for registering for remote notifications. Added in conditional code to tell the compiler which piece of code to use for iOS7 and iOS8 so that it is backwards compatible, tested on iOS8 and iOS7 successfully.