Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Conformance page to allow back and forward history #150

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Apr 14, 2024

This is related to #148. Posting as draft for now.

It adjusts the conformance page to allow traversing through history backwards and forwards.

It also adds default alphabetical sorting! 😄

EDIT: I'm still sort of testing it out for edge cases as it's a new way of handling state in React that I'm not entirely familiar with. So if anyone notices anything or tries it out and is having issues, let me know.

@nekevss nekevss mentioned this pull request Apr 14, 2024
7 tasks
@nekevss nekevss marked this pull request as ready for review April 14, 2024 15:49
@nekevss nekevss requested a review from a team April 14, 2024 16:29
@nekevss nekevss added the enhancement New feature or request label Apr 14, 2024
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jedel1043 jedel1043 requested review from a team and jasonwilliams April 14, 2024 23:00
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works perfectly! :)

@HalidOdat HalidOdat requested a review from a team April 15, 2024 03:59
@nekevss nekevss merged commit 3842ab5 into main Apr 16, 2024
1 check passed
@nekevss nekevss deleted the conformance-refactor branch April 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants