-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft of Effective tab for BndEditor #6406
base: master
Are you sure you want to change the base?
first draft of Effective tab for BndEditor #6406
Conversation
426c073
to
9c48429
Compare
18e94ee
to
52ea878
Compare
@pkriens this is the current status of the "Effective" tab in the BndEditor
Further TODOs could be:
Let me know when you want to take over for more magic :) |
I might take a stab in the next 2 weeks when I am not allowed to sit in my office :-) |
ce00b37
to
a3623f7
Compare
Signed-off-by: Christoph Rueger <[email protected]> add find text via CMD+F Signed-off-by: Christoph Rueger <[email protected]> add Syntax highlighting via SourceViewer remove unnecessary code remove some code which came in from JarPrintPage.java Signed-off-by: Christoph Rueger <[email protected]> fix resource bundle found in org.eclipse.ui.texteditor.EditorMessages.BUNDLE_FOR_CONSTRUCTED_KEYS which is unfortunatelly not accessible (private) Signed-off-by: Christoph Rueger <[email protected]> add line numbers Signed-off-by: Christoph Rueger <[email protected]> rename tab just "Effective" Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]> remove file
Signed-off-by: Christoph Rueger <[email protected]>
use resizable SashForm Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
and finally fix the scrolling issues by borrowing StackLayout from JARPrintPage.java Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
this gives more flexibility when working with the values since we just don't have strings only Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
42e19c5
to
6286697
Compare
Thanks. I have pushed some improvements. Hope that might be a good place to takeover.
|
--- Signed-off-by: github-actions <[email protected]> Signed-off-by: github-actions <[email protected]>
All the different places where we set properties now mark their provenance. In the case of the original we mark the original propertiesFile, in case of includes we track the included file. For defaults we use the provenance as a comment --- Signed-off-by: github-actions <[email protected]> Signed-off-by: github-actions <[email protected]>
We now maintain a list of merge property keys in Constants. The BndEdit Model now try to see if a property is part of a merge header and use the proper converter/formatter. --- Signed-off-by: github-actions <[email protected]> Signed-off-by: github-actions <[email protected]>
--- Signed-off-by: github-actions <[email protected]> Signed-off-by: github-actions <[email protected]>
adds a first draft of an readonly "Effective Source view" of a Bnd Editor based on comment #6401 (comment)
This is a nice additional debugging tool, because it makes things visible to the human eye, which were previously hidden.
Comment about code: I reused some code of the JarEditor (JarPrintPage.java) and added search-dialog and syntax highlighting. Sorry if this is not state-of-the-art Eclipse JFace code.