Add search bar to Unresolved requirements in ResolutionFailedPanel #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to search the list of unresolved requirements. IMO this helps to make sense of this list, because without a search it is hard to "see" anything there Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
|
LGTM, can we merge? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a search bar to this view:
I found that helpful, because before I could never make sense of that list, because I couldn't "see" / or "find" anything (can't see the forest for the trees).
Now the search bar at least allows to search for anything from the error message above, and maybe find what is of interest for you.
Note on search bar positioning: The search bar currently is at the bottom, because I could't find a way to add it below the "Unresolved requirements" header. I managed to add it right above the "Unresolved requirements" header, but there I did not like it because it does not look like it belongs to the "Unresolved requirements".
Maybe because it is a collapsible tree or some view panel which does not allow this. I don't know.
I personally don't find that bad, but it is a bit different than other views where the search bar is at the top.