fix: use cache first when get StorageTrie/Trie #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish-nr
force-pushed
the
fix_trie_cache
branch
from
de4694e to
4238519
Compare
j75689
reviewed
Oct 13, 2023
krish-nr
force-pushed
the
fix_trie_cache
branch
from
4238519 to
d3e61fb
Compare
krish-nr
force-pushed
the
fix_trie_cache
branch
from
d3e61fb to
7655b97
Compare
boolafish
reviewed
Oct 24, 2023
bendanzhentan
approved these changes
Jan 5, 2024
|
Have you ever tested it in PBSS mode? |
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Jul 25, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Jul 29, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Aug 7, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Aug 13, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Sep 25, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Oct 11, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Oct 31, 2024
* revert: txpool pending cache optimization * Revert "fix ut" This reverts commit 8d4302b. * Revert "fix ut" This reverts commit 06d810d. * Revert "fix ut" This reverts commit 4ba1d24. --------- Co-authored-by: andyzhang2023 <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Nov 14, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
referenced
this pull request
in sunny2022da/op-geth
Dec 11, 2024
…ng; (#10) * txdag: support txdag transfer in extra; * txdag: support txdag transfer in extra; --------- Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In core/state/database.go , the CacheAccount() and CacheStorage() functions call Add() on accountTrieCache and storageTrieCache but not used when getting them.
Rationale
Add cache getting first logic in OpenTrie() and OpenStorageTrie
Changes
try to get cache first when access Account and Storage, and update cache after that.