fix: oom in bundlepool #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to pprof on heap as below pictures from left to right, there are a lot of new memory assigned when sendBundle, The program keeps holding this memory without freeing it.
Further analysis of the code, every time a new block comes out, only
p.bundleshas been cleared, notbundleheap,bundleheapwould keep large amount of depracated bundles. So we also cleanup the bundlehea at this time.Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: