fix: revert for droppable tx receipt failed #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix is for the following cases:
First, it needs to be clear that when evm execution is successful but receipt is failed, the state will finalise, and the external call layer cannot reset any operations on the state.
A droppable&unrevertible transaction is executed successfully at the index position N of the bundle, but receipt is false, and the gasfee is deducted from the sender balance.
If the droppable transaction is deleted, it is inconsistent with the evm state behavior. If the index of bundle is N+1 and there are transactions with the same sender, faults such as insufficient balance may occur, which is inconsistent with the expectation.
Solution: Extend the evm transaction execution method, when droppable transaction execution is successful but receipt is failed, it directly returns err, and the outer layer decides whether revert.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: