Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert for droppable tx receipt failed #65

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

irrun
Copy link
Collaborator

@irrun irrun commented Jan 7, 2025

Description

This fix is for the following cases:
First, it needs to be clear that when evm execution is successful but receipt is failed, the state will finalise, and the external call layer cannot reset any operations on the state.

  1. A droppable&unrevertible transaction is executed successfully at the index position N of the bundle, but receipt is false, and the gasfee is deducted from the sender balance.

  2. If the droppable transaction is deleted, it is inconsistent with the evm state behavior. If the index of bundle is N+1 and there are transactions with the same sender, faults such as insufficient balance may occur, which is inconsistent with the expectation.

  3. Solution: Extend the evm transaction execution method, when droppable transaction execution is successful but receipt is failed, it directly returns err, and the outer layer decides whether revert.

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@irrun irrun marked this pull request as ready for review January 23, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant