Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update project #196

Merged
merged 17 commits into from
Dec 25, 2023
Merged

update project #196

merged 17 commits into from
Dec 25, 2023

Conversation

miguelcobain
Copy link
Collaborator

No description provided.

@miguelcobain
Copy link
Collaborator Author

@bmeurant this is my proposal for this addon.

Let me explain what this does.

First, there's this text I added to the README:

In recent Ember versions, you problem don't need an addon for this case.
With the introduction of helper functions, you can just easily create a local helper
that checks if an element is contained in an array.

If you want the helper to react to add/removals, you should be using some version of a "reactive" array. Either EmberArray or TrackedArray from tracked-built-ins. See demo here.

In any case, this addon should be compatible with basically every ember version from 3.28 to 5.x.

So, the goal of this PR is to make this addon as compatible as possible and then "forget" about it. Meaning that people should probably be using different approaches in their apps nowadays.

I managed to get this addon compatible up to latest ember 5! (even canary)

image

Because the dummy app and tests are "linked", I had to give up on the dummy app. ember-paper was causing a lot of issues.

I hope this provides a good state to leave this addon.

@bmeurant
Copy link
Owner

Hi @miguelcobain Thank you very much!

I fully agree on your proposal to leave it as clean as possible and then to forget about it as it exists, now, more "native approaches" in ember.

I'll still have to clear the readme of obsolete sections (docs, demo, etc.)

Many thanks, again

@bmeurant bmeurant merged commit 195484f into master Dec 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants