Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit codes from launched process when using hab launch #90

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

MHendricks
Copy link
Member

Currently when using hab launch for all shells if the launched process errors out, that exit code is not propagated to the calling shell. This PR fixes that and adds tests for it.

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

@MHendricks MHendricks force-pushed the mikeh/returncodes branch 7 times, most recently from b048c40 to 4f6cdf0 Compare January 15, 2024 18:16
TODO: Figure out the correct way to call the bash tests so we can remove
the skip marks.
TODO: Figure out how to test PowerShell on github actions without it timing out
@MHendricks MHendricks merged commit 3b6dc37 into main Jan 15, 2024
31 checks passed
@MHendricks MHendricks deleted the mikeh/returncodes branch January 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant