Add Omittable Distro support per URI config #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
force-pushed
the
mikeh/omit_dists
branch
from
fba76cf to
d5acc0a
Compare
MHendricks
force-pushed
the
mikeh/omit_dists
branch
3 times, most recently
from
aee1561 to
bfa6aac
Compare
`hab.utils.dumps_json` now enables sort_keys by default. This makes it so the resulting json data is consistently ordered.
Switch from processing all properties on the current node, then checking the parent if any were NotSet to fully processing each property in sort_key order before moving on to the next property. This fixes an bug where distro global env vars are not added to the global env when distro is inherited. This also makes it so hab_properties can be defined only on parent or default.
This allows you to override the requirements per-config instead of having to modify the global setting stored on the Resolver instance.
MHendricks
force-pushed
the
mikeh/omit_dists
branch
from
bfa6aac to
5a288a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Types of Changes
Proposed Changes