WinPlatform.normalize_path no longer changes the UNC drive case

blurstudio · Dec 4, 2024 · 177503d · 177503d
1 parent a429d01
commit 177503d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/hab/utils.py b/hab/utils.py
@@ -581,7 +581,8 @@ def normalize_path(cls, path):
 
         This ensures that the drive letter is resolved consistently to uppercase.
         """
-        if not path.is_absolute():
+        # Don't change the case of relative or UNC paths
+        if not path.is_absolute() or ":" not in path.drive:
             return path
         parts = path.parts
         cls = type(path)

diff --git a/tests/test_resolver.py b/tests/test_resolver.py
@@ -851,8 +851,12 @@ def test_normalize_path_preserves_cls(self, cls, platform):
             # the drive letter is always upper-cased if specified
             (r"c:\temp", "C:/temp"),
             (r"C:\temp", "C:/temp"),
+            (r"C:\teMP", "C:/teMP"),
             (r"z:\subfolder", "Z:/subfolder"),
             (r"relative\path", "relative/path"),
+            # UNC file paths do not have case changed
+            (r"\\unc\share\folder", "//unc/share/folder"),
+            (r"\\UnC\shaRe\folDer", "//UnC/shaRe/folDer"),
         ),
     )
     def test_normalize_path_windows(self, path, check):