fix MimeMessage::formatAddress not protecting recipient names #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings !
Right now, trying to send an email, to someone whose name contains a comma, results in a ClientError. According to the following topic :
https://stackoverflow.com/questions/15555563/how-to-format-an-email-from-header-that-contains-a-comma
... it seems that to prevent this issue, names in mail headers should be escaped using double quotes. This pull request achieves this result using stringstream and some iomanip magic. It does imply a back-and-forth conversion between QByteArray and std::string... but I don't believe Qt provides their own implementation for something like std::quoted, so this seemed like the simplest way to reach the goal.