New spanish translations #7319

dgruano · 2024-12-31T21:48:12Z

As promised, some more updates for the Spanish localization:

Add new translations to reach 100% coverage
Change example name from Alice to Alicia in all examples
Make new strings translatable
- "Posts" and "Publications" (lists page) and "Following" tab
- Run lingui extract
- Add translation to Spanish for those strings
Some fixes:
- Roll back to "Me gusta" for the "Likes" tab in profile (my bad)
- Change "desmutear" and derivatives to "Dejar de silenciar"
- Other minor fixes
To validate:
- src/screens/Profile/components/ProfileFeedHeader.tsx:353
  menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")?
- src/view/screens/ProfileList.tsx:683 (and others)
  Dejar de fijar?"
TODO: Delete obsolete strings from locales. Is there any criteria to do this, or can they be deleted right away?

- Add new translations to reach 100% coverage - Change example name from Alice to Alicia in all examples - Change "desmutear" and derivatives to "Dejar de silenciar" - Remove comments - Minor fixes

- "Posts" and "Publications" (lists page) and "Following" tab - Run lingui extract - Translate those strings to Spanish - Translate other remaining strings to Spanish To validate: src/screens/Profile/components/ProfileFeedHeader.tsx:353 menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")? src/view/screens/ProfileList.tsx:683 (and others) Dejar de fijar?" TODO: Delete obsolete strings from locales

auroursa · 2025-01-01T13:16:21Z

src/view/screens/ProfileList.tsx

@@ -162,6 +159,7 @@ function ProfileListScreenLoaded({
  const isHidden = list.labels?.findIndex(l => l.val === '!hide') !== -1
  const isOwner = currentAccount?.did === list.creator.did
  const scrollElRef = useAnimatedRef()
+  const SECTION_TITLES_CURATE = [_(msg`Posts`), _(msg`People`)]


#7175 is already working on this, I suggest keeping it separate from the Spanish translation update PR to avoid overlaps.

Oh thanks! I didn't notice. Will roll back the changes then.

auroursa · 2025-01-01T13:19:12Z

Let’s first resolve some merge conflicts. When updating messages.po, please specify the language, for example:
yarn intl:extract --locale es

This ensures we keep changes scoped to Spanish translations only.

- Solved conflicts in Spanish locale - "Theirs" strategy for the rest of locales - Rollback ProfileList.tsx to avoid overlap with bluesky-social#7175

dgruano · 2025-01-01T19:08:13Z

I think that should solve the merge conflicts. What I did:

Merge "main" onto my locale branch, keeping all files from "main" and resolving conflicts between branches for the Spanish locale. This includes rolling back my changes to ProfileList.tsx to localize the tab titles.
Fix a typo duplicated string "Start adding people!" with and without exclamation in ProfileList.tsx
Extract and translate only es locale, as suggested.

Thank you for your help and guidance! Happy to make any other changes if needed.

auroursa · 2025-01-02T01:18:39Z

Thank you for your efforts, but could we revert the changes to messages.po files for all languages except Spanish? Updating all languages makes the PR harder to review.

I noticed your improvements to src/state/queries/feed.ts and src/view/screens/ProfileList.tsx—great work! But I believe these changes should be reviewed in a separate PR to keep this one focused solely on updating the Spanish language files. This approach would help to expedite the merging process.

auroursa · 2025-01-02T01:22:49Z

@GersonLazaro @ovniroto Would anyone be willing to review the improvements proposed in this PR? It would be great if someone could take a look!

src/locale/locales/es/messages.po

ovniroto · 2025-01-14T12:33:13Z

src/locale/locales/es/messages.po


 #: src/screens/Post/PostLikedBy.tsx:41
 msgid "{0, plural, one {# like} other {# likes}}"
-msgstr ""
+msgstr "{0, plural, one {# \"me gusta\"} other {# \"me gusta\"}}"


This should be without quotation marks. All other words such as "citas" or "reposts" do not have quotation marks.

The translation has a small problem. There are places where there should be quotation marks, such as in phrases that determine that someone has given a like, as here:

However, in places where only the word "me gusta" appears, it should not have quotation marks, as here:

It would be good to identify the lines that have these problems.

This particular translation is solved in the current PR.

social-app/src/locale/locales/es/messages.po

Lines 4331 to 4333 in a0252d3

#: src/screens/Profile/components/ProfileFeedHeader.tsx:514

msgid "Like"

msgstr "Me gusta"

The other lines with this problem are:

social-app/src/locale/locales/es/messages.po

Line 118 in a0252d3

msgstr "{0, plural, one {\"me gusta\"} other {\"me gusta\"}}"

and maybe:

social-app/src/locale/locales/es/messages.po

Line 4337 in a0252d3

msgstr "Me gusta ({0, plural, one {# \"me gusta\"} other {# \"me gusta\"}})"

social-app/src/locale/locales/es/messages.po

Line 8753 in a0252d3

msgstr "Ya no me gusta ({0, plural, one {# \"me gusta\"} other {# \"me gusta\"}})"

What do you think?

Yes, the quotation marks should disappear in the me gusta that appear in the posts controls, specifically in those lines you mention.

dgruano · 2025-01-19T12:48:08Z

Hi all! I believe I have integrated all of your coments. Do you have anything else to review or can we move forward? Thanks!

ArtfulAzeria · 2025-01-20T12:59:56Z

If i'm not wrong, the current state has changes for the translation of mute to silenciar. If that's the case and is being worked here, may I suggest to change dejar de silenciar and similar occurrences with desilenciar?
The use is grammatically correct, and easier to fit in smaller displays and boxes.

For reference on its use, the RAE suggested the form desilenciar on twitter in 2018 and ratified it with this newer twit in 2023.

Wiktionary also accepts the form.

dgruano · 2025-01-21T07:06:02Z

If i'm not wrong, the current state has changes for the translation of mute to silenciar.

It does! I made those changes following the same principle as in #6094 , where it was preferred to translate "starter pack" to "paquete de inicio" instead of "pack de inicio"

If that's the case and is being worked here, may I suggest to change dejar de silenciar and similar >occurrences with desilenciar? The use is grammatically correct, and easier to fit in smaller displays and >boxes.

For reference on its use, the RAE suggested the form desilenciar on twitter in 2018 and ratified it with this newer twit in 2023.

Wiktionary also accepts the form.

What I understand is that the RAE said it exists, its written with only one s, and is preferred to use "dejar de silenciar". While grammatically correct, its limited use may make it sound odd (it does to me). However, I understand the technical implications of using a short vs a long translation and I'm happy to change this if needed!

ovniroto

The quotation marks in the phrase me gusta should disappear in the post controls on the lines mentioned in this comment #7319 (comment)

dgruano added 3 commits December 31, 2024 20:42

Add new es translations

51db00a

100% coverage and minor corrections

fe4d3f5

- Add new translations to reach 100% coverage - Change example name from Alice to Alicia in all examples - Change "desmutear" and derivatives to "Dejar de silenciar" - Remove comments - Minor fixes

auroursa reviewed Jan 1, 2025

View reviewed changes

dgruano added 3 commits January 1, 2025 18:48

Merge branch 'main' into new-spanish-translations

cc4d787

- Solved conflicts in Spanish locale - "Theirs" strategy for the rest of locales - Rollback ProfileList.tsx to avoid overlap with bluesky-social#7175

Fix exclamation point typo in ProfileList.tsx

449b71c

Extract es translations and translate new strings

ff6693f

GersonLazaro reviewed Jan 2, 2025

View reviewed changes

src/locale/locales/es/messages.po Outdated Show resolved Hide resolved

src/locale/locales/es/messages.po Outdated Show resolved Hide resolved

src/locale/locales/es/messages.po Outdated Show resolved Hide resolved

dgruano added 4 commits January 2, 2025 13:17

Rollback changes in other locales

ed1dc4c

Rollback changes other than /es/messages.po

d751bb1

Extract es localization to reflect changes

255ffad

Apply changes suggested in review

5810c92

ovniroto reviewed Jan 6, 2025

View reviewed changes

src/locale/locales/es/messages.po Outdated Show resolved Hide resolved

Fix small typo

3388c6e

ovniroto reviewed Jan 14, 2025

View reviewed changes

Remove quote marks when "me gusta" is not in sentence

a0252d3

ArtfulAzeria mentioned this pull request Jan 20, 2025

Typos in spanish translation #6093

Open

dgruano requested review from auroursa, ovniroto and GersonLazaro January 21, 2025 07:06

ovniroto reviewed Jan 21, 2025

View reviewed changes

Remove quotation marks for "me gusta" in all needed ocurrences

4d348ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New spanish translations #7319

New spanish translations #7319

dgruano commented Dec 31, 2024

auroursa Jan 1, 2025

dgruano Jan 1, 2025

auroursa commented Jan 1, 2025

dgruano commented Jan 1, 2025

auroursa commented Jan 2, 2025

auroursa commented Jan 2, 2025

ovniroto Jan 14, 2025 •

edited

Loading

ovniroto Jan 14, 2025

dgruano Jan 14, 2025

ovniroto Jan 21, 2025

dgruano commented Jan 19, 2025

ArtfulAzeria commented Jan 20, 2025

dgruano commented Jan 21, 2025

ovniroto left a comment

	#: src/screens/Profile/components/ProfileFeedHeader.tsx:514
	msgid "Like"
	msgstr "Me gusta"

New spanish translations #7319

Are you sure you want to change the base?

New spanish translations #7319

Conversation

dgruano commented Dec 31, 2024

auroursa Jan 1, 2025

Choose a reason for hiding this comment

dgruano Jan 1, 2025

Choose a reason for hiding this comment

auroursa commented Jan 1, 2025

dgruano commented Jan 1, 2025

auroursa commented Jan 2, 2025

auroursa commented Jan 2, 2025

ovniroto Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

ovniroto Jan 14, 2025

Choose a reason for hiding this comment

dgruano Jan 14, 2025

Choose a reason for hiding this comment

ovniroto Jan 21, 2025

Choose a reason for hiding this comment

dgruano commented Jan 19, 2025

ArtfulAzeria commented Jan 20, 2025

dgruano commented Jan 21, 2025

ovniroto left a comment

Choose a reason for hiding this comment

ovniroto Jan 14, 2025 •

edited

Loading