Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ping2 support #1081

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jun 11, 2024

@patrickelectric patrickelectric changed the title sensor: ping: Use Common:DEVICE_INFORMATION over Ping1d::FIRMWARE_VERSION Add Ping2 support Jun 11, 2024
Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some usage notes:

  • Firmware flashing (still) works 👍
  • Firmware filtering for the Automatic Update works 👍, but only for the device type that was initially connected to 🫤
    • If a firmware with a different device type is manually flashed, the filtering is still based on the old device type until Ping Viewer restarts
      • In principle this is a bug, but we also don't expect users to change their device type, so I don't think it's a big deal 🤷‍♂️
  • Once flashed, the Ping2-V1.1.0 firmware registers as 1.0 (instead of 1.1) in the "Current Firmware" indicator, in both the debug window and the firmware flashing window EDIT: Fixed
    • I confirmed with ping-python that this is at least partially a problem with the firmware not having an internally updated version, which makes it unclear whether Ping Viewer will display the value correctly
  • The debug menu doesn't show the patch version (just major, minor), even though newer firmwares (Ping2, Ping360) are specified with one
    • This isn't new, so may not need to be handled in this PR
  • Ping2 firmwares seem to only show up as 115200 baud options, whereas original Ping firmwares show up as both 9600 and 115200 options EDIT: both were showing up, 9600 just took much longer to appear 🤷‍♂️
    • No idea if this was an intentional change in the firmware, or a problem, just noting that it's different
  • The interplay between the "Firmware Update" button and the progress bar is currently confusing
    • This isn't new, so doesn't necessarily need to be handled in this PR
    • Specifically, when a firmware is not being flashed the indefinite progress bar seems unnecessary, and has consistently made me think it's indicating that flashing has started once I select a manual firmware file, before realising I have to press the "Firmware Update" button to confirm

@patrickelectric
Copy link
Member Author

Once flashed, the Ping2-V1.1.0 firmware registers as 1.0 (instead of 1.1) in the "Current Firmware" indicator, in both the debug window and the firmware flashing window

  • I confirmed with ping-python that this is at least partially a problem with the firmware not having an internally updated version, which makes it unclear whether Ping Viewer will display the value correctly

I just fixed it, can you take a look ?

@ES-Alexander
Copy link
Contributor

I just fixed it, can you take a look ?

Confirmed that this is fixed - thanks :-)

@patrickelectric
Copy link
Member Author

Ping2 firmwares seem to only show up as 115200 baud options, whereas original Ping firmwares show up as both 9600 and 115200 options

  • No idea if this was an intentional change in the firmware, or a problem, just noting that it's different

It's fine over here, try to connect and disconnect to restart the ABR procedure.

@ES-Alexander
Copy link
Contributor

It's fine over here, try to connect and disconnect to restart the ABR procedure.

Just tried again, and 9600 did show up eventually, it just took about twice as long as 115200 🤷‍♂️

Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My remaining previous suggestions/comments still stand, but they don't need to be handled in this PR.

Approving, since this is already mergeable :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ping1 firmware update options showing for a Ping2 device
2 participants