Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib #2578

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use pathlib #2578

wants to merge 9 commits into from

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Dec 23, 2024

Outside of the convenience functions it also helps with typing. I tested transfers and this works for me. The NetConf bits need a proper testing which I haven't done yet.

Overall I think it's an improvement.

@infirit
Copy link
Contributor Author

infirit commented Dec 23, 2024

I am confused, how are these forwarding files created at all in main 🤔 .

edit: Is NetConf supposed to create them maybe...

edit2: It does so my glob is failing here. Need to fix the test so it prepares the files in the setup.

@infirit infirit force-pushed the pathlibv2 branch 5 times, most recently from da2b9cd to 1112300 Compare December 23, 2024 11:52
@infirit
Copy link
Contributor Author

infirit commented Dec 23, 2024

Tested the dhcp servers and after fixing issues in udhcp all start and stop properly for me.

@infirit infirit marked this pull request as ready for review December 23, 2024 14:51
@infirit infirit requested a review from cschramm December 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant