-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pathlib #2578
base: main
Are you sure you want to change the base?
Use pathlib #2578
Conversation
I am confused, how are these edit: Is NetConf supposed to create them maybe... edit2: It does so my glob is failing here. Need to fix the test so it prepares the files in the setup. |
da2b9cd
to
1112300
Compare
It's used in TransferService.
The NetConf test now explicitely creates the sysfs forwarding files and not have NetConf create them.
Quality Gate passedIssues Measures |
Tested the dhcp servers and after fixing issues in udhcp all start and stop properly for me. |
Outside of the convenience functions it also helps with typing. I tested transfers and this works for me. The NetConf bits need a proper testing which I haven't done yet.
Overall I think it's an improvement.