Make hexbin locations deterministic #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that bothered my for quite a while is the fact that hexbin locations move around every time you zoom in or out. It turns out that the locations where calculated relative to the Pixel Origin, which itself is also a relative value compared to Leaflet map's CRS. As a result, the hexbins would never look the same.
This PR modifies the hexbin locations to be calculated relative to the map CRS instead (
projectinstead oflatLngToLayerPoint) and subsequently translate the resulting hexbin locations to the Pixel Origin reference system by subtracting the PO value from the hexbin locations.As a result, the hexbin locations remain constant across zoomlevels and will look the same for everyone everytime. (Which in turn also makes it easier to fix the hexbin radius as discussed in #14, because the locations now always stay the same.)
@reblace it would be great to hear from you :)