feat: add View Logs to System Header Menu (ENG-55440) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abartella-bc
commented
Apr 11, 2024
•
abartella-bc
commented
- Change condition for HeaderSystemMenu component to be displayed when a user has permission to view logs OR permission to download logs
- Added view logs option in dropdown
- Added pseudo-translation for view logs option
- Updated HeaderSystemMenu, Header, and SimplePage in storybook
- Updated tests to include view logs option
ajbasnet
reviewed
Apr 15, 2024
| @@ -81,6 +81,7 @@ const platformMockValue = { | |||
| ], | |||
| permissions: { | |||
| download_logs: true, | |||
| view_logs: true, | |||
There was a problem hiding this comment.
It would be useful to mention view logs somewhere in Limani Story book, similar to existing Download Logs.
There was a problem hiding this comment.
I added a brief description, lmk what you think. (located in HeaderSystemMenu.js)
ajbasnet
reviewed
Apr 15, 2024
src/header/HeaderSystemMenu.js
Outdated
| * all logs as a single file. <br> | ||
| * With user access permission, two options for retrieving logs are available. | ||
| * "Download logs" retrieves all logs as a single file, and "View logs" allows | ||
| * the 1000 lines of the log to be viewed in the UI, where they can be |
There was a problem hiding this comment.
How about
View logs shows the last 1000 lines of relevant Gateway logs, providing searching and filtering options.
ajbasnet
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.