Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.max(np.abs(x_re[:, np.newaxis] - x_re[np.newaxis, :]), axis=2) <= r
was identified as a hotspot on the scalene profiler.*This PR speeds this up.
Here is a snippet of before optimisations made:
Here is after changes made:
Does not change much... so this may be a red herring hotspot. Profiling the individual line change showed a massive speedup, but overall it harms performance... leaving in draft for now
Reproduce profiling results with:
Scalene profiler appears to be more informative than other python profiling tooIs (that I know of)