fix: use correct flag for postinstall auto-complete command #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
create-app 📂
murtyjones
approved these changes
Jan 13, 2025
molisani
force-pushed
the
fix/auto-complete-install-args
branch
from
14ecdd4 to
a4c1f93
Compare
Signed-off-by: Michael Molisani <[email protected]>
molisani
force-pushed
the
fix/auto-complete-install-args
branch
from
a4c1f93 to
6284127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
Describe your changes
When using the
singletemplate, there is no command built-in to the app for installing the auto-complete functionality. Instead, the postinstall script for the app calls theinstallcommand of the@stricli/auto-complete@latestpackage (vianpx). There with this postinstall script where it was passing the bash command as a positional parameter and not a flag. This is now resolved.Testing performed
Updated baselines, confirmed by running manually.