Automatically check our offsets against CPython's self-reported debug offsets #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
check_against_debug_offsets
branch
from
742bc7a to
cc5a076
Compare
There's a new `co_executors` field added above `co_code_adaptive`, so our offset for `co_code_adaptive` was off by the size of a pointer. Signed-off-by: Matt Wozniski <[email protected]>
The `generation0` member has been removed. Signed-off-by: Matt Wozniski <[email protected]>
Since Python 3.13, the interpreter embeds some metadata in the PyRuntimeState structure to help debugging tools locate the information they need. Check the offsets we're using against the offsets that CPython says we should be using, and warn if they're different. Signed-off-by: Matt Wozniski <[email protected]>
This lays the groundwork for us to be able to adjust to changes in the layout of the debug offsets from one version of Python to the next. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
check_against_debug_offsets
branch
from
cc5a076 to
e782f37
Compare
pablogsal
approved these changes
Aug 7, 2024
|
Man, so glad we this this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix two mistakes that were uncovered by this!