Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return with failure if we can't resolve hostname to address #4874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Return with failure if we can't resolve hostname to address #4874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions db/comdb2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ int gbl_osql_verify_ext_chk = 1;

int gbl_test_badwrite_intvl = 0;
int gbl_test_blob_race = 0;
int gbl_test_resolve_hostname_failure = 0;
int gbl_skip_ratio_trace = 0;

int gbl_throttle_sql_overload_dump_sec = 5;
Expand Down
1 change: 1 addition & 0 deletions db/db_tunables.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ extern int gbl_altersc_latency_inc;
extern int gbl_sc_history_max_rows;
extern int gbl_sc_status_max_rows;
extern int gbl_rep_process_pstack_time;
extern int gbl_test_resolve_hostname_failure;

extern void set_snapshot_impl(snap_impl_enum impl);
extern const char *snap_impl_str(snap_impl_enum impl);
Expand Down
2 changes: 2 additions & 0 deletions db/db_tunables.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2454,6 +2454,8 @@ REGISTER_TUNABLE("multitable_ddl",
"Enables single schema change object ddl implementation (default: off)",
TUNABLE_BOOLEAN, &gbl_multitable_ddl, 0, NULL, NULL, NULL, NULL);

REGISTER_TUNABLE("test_resolve_hostname_failure", "Tunable to test hostname resolution failure",
TUNABLE_INTEGER, &gbl_test_resolve_hostname_failure, 0, NULL, NULL, NULL, NULL);
REGISTER_TUNABLE("sc_history_max_rows", "Max number of rows returned in comdb2_sc_history (Default: 1000)",
TUNABLE_INTEGER, &gbl_sc_history_max_rows, 0, NULL, NULL, NULL, NULL);
REGISTER_TUNABLE("sc_status_max_rows", "Max number of rows returned in comdb2_sc_status (Default: 1000)",
Expand Down
1 change: 1 addition & 0 deletions tests/tunables.test/t00_all_tunables.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,7 @@
(name='test_ddl_backout_nomaster', description='Force a NOMASTER error in toblock.', type='BOOLEAN', value='OFF', read_only='N')
(name='test_delay_analyze_commit', description='Delay analyze commit', type='BOOLEAN', value='OFF', read_only='N')
(name='test_io_time', description='Check I/O in watchdog this often', type='INTEGER', value='10', read_only='N')
(name='test_resolve_hostname_failure', description='Tunable to test hostname resolution failure', type='INTEGER', value='0', read_only='N')
(name='test_sc_resume_race', description='Test race between schemachange resume and blockprocessor', type='BOOLEAN', value='OFF', read_only='Y')
(name='test_scindex_deadlock', description='Test index on expressions schema change deadlock', type='BOOLEAN', value='OFF', read_only='Y')
(name='test_sql_time', description='Check SQL in watchdog this often', type='INTEGER', value='0', read_only='N')
Expand Down