feat: include git commit in schema #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2025
Open
Open
alecthomas
reviewed
Mar 5, 2025
alecthomas
requested changes
Mar 5, 2025
|
Disregard! |
alecthomas
reviewed
Mar 5, 2025
| @@ -329,6 +330,12 @@ message MetadataCalls { | |||
| repeated Ref calls = 2; | |||
| } | |||
|
|
|||
| message MetadataCommit { | |||
| optional Position pos = 1; | |||
There was a problem hiding this comment.
As discussed over DM, would be great to have the Git repo here, and maybe rename this to MetadataVCS
alecthomas
approved these changes
Mar 5, 2025
stuartwdouglas
force-pushed
the
stuartwdouglas/3277
branch
2 times, most recently
from
22fcfcc to
fe71951
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/3277
branch
from
274528f to
0246cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3277