Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build engine handles module interface changes with dependencies #4779

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Mar 5, 2025

Changes:

  • Split off deploy logic from build engine into buildengine.DeployCoordinator
    • It coordinates when each deploy is ready to be submitted to the schema service
    • It detects when a deploy would make dependant modules fail, and queues that deploy until those modules have been rebuilt succesfully and then deploys them all in a single transaction
  • Deploy coordinator now owns the schema update stream from schema service, and publishes an altered version to the build engine. When it queues a change that requires dependant modules to be rebuilt, it changes this schema for the build engine:
    • Updates the module schema for the pending deployment (so that dependencies can build against the target schema)
    • Removes transitive dependencies of the pending deployment from the schema (as they would cause an invalid schema)
  • admin.ApplyChangeset is now a stream so that DeployCoordinator can get the changeset key without waiting for the changeset to complete

@matt2e matt2e requested review from a team and alecthomas as code owners March 5, 2025 00:55
@alecthomas alecthomas mentioned this pull request Mar 5, 2025
@matt2e matt2e force-pushed the matt2e/deploy-coordination branch from a8ad846 to cab507b Compare March 5, 2025 02:32
@matt2e matt2e force-pushed the matt2e/deploy-coordination branch from cab507b to 7f53e3c Compare March 5, 2025 02:32
@matt2e matt2e force-pushed the matt2e/deploy-coordination branch from 9b22b7a to 0796782 Compare March 5, 2025 03:48
@matt2e matt2e requested a review from stuartwdouglas March 5, 2025 04:13
@matt2e matt2e force-pushed the matt2e/deploy-coordination branch from 5c0bec1 to 1a33a34 Compare March 5, 2025 04:23
@matt2e matt2e merged commit 0ae33a2 into main Mar 5, 2025
68 checks passed
@matt2e matt2e deleted the matt2e/deploy-coordination branch March 5, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants