feat: recreate DB on schema change #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2025
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/recreate-on-schema-change
branch
2 times, most recently
from
fdd374b to
6b651e8
Compare
stuartwdouglas
changed the title
stuartwdouglas
force-pushed
the
stuartwdouglas/recreate-on-schema-change
branch
from
6b651e8 to
2a4c9d2
Compare
stuartwdouglas
commented
Mar 6, 2025
| Config: &Database{Type: d.Type, Metadata: []Metadata{migration}}, | ||
| Kind: ResourceTypeSQLMigration, | ||
| Config: &Database{Type: d.Type, Metadata: []Metadata{migration}}, | ||
| DeploymentSpecific: true, |
There was a problem hiding this comment.
This means that provision will always be called, even when databases are the same. I'm not sure what impact this would have for the other DB provisioners.
jvmakine
approved these changes
Mar 6, 2025
stuartwdouglas
force-pushed
the
stuartwdouglas/recreate-on-schema-change
branch
2 times, most recently
from
e526814 to
a7c3e48
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/recreate-on-schema-change
branch
2 times, most recently
from
6d2f509 to
bb169c6
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/recreate-on-schema-change
branch
from
bb169c6 to
f7a2e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.