Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Juho): optional proto #4119

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(Juho): optional proto #4119

wants to merge 1 commit into from

Conversation

jvmakine
Copy link
Contributor

This also automatically adds optional protobuf config if that is not set

@jvmakine jvmakine requested review from alecthomas and a team as code owners January 20, 2025 04:56
@github-actions github-actions bot changed the title Juho/optional proto feat(Juho): optional proto Jan 20, 2025
@alecthomas alecthomas mentioned this pull request Jan 20, 2025
@jvmakine jvmakine force-pushed the juho/optional-proto branch from 0b09850 to 35ed2fb Compare January 20, 2025 05:11
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cmd/go2proto/testdata/go2proto.to.go Outdated Show resolved Hide resolved
@jvmakine jvmakine marked this pull request as draft January 20, 2025 06:18
@jvmakine jvmakine force-pushed the juho/optional-proto branch 4 times, most recently from b6295bb to 22610cd Compare January 21, 2025 04:55
@jvmakine jvmakine force-pushed the juho/optional-proto branch from 22610cd to 34a42dd Compare January 21, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants