fix: use proto to communicate with Hot Reload process #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-fixes
branch
7 times, most recently
from
52e64dc to
4dd60a0
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-fixes
branch
from
4dd60a0 to
76e31e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress, but the intention here is that gRPC is now used to communicate between the JVM hot reload process and the plugin. This will allow FTL to have more control over the process, rather than relying on the Quarkus native hot reload behaviour.