Skip to content

Commit

Permalink
Merge pull request #27 from jfederico/master
Browse files Browse the repository at this point in the history
Fix for issue #26
jfederico authored Sep 21, 2017
2 parents c29046c + 9ddfa70 commit a44191b
Showing 6 changed files with 7 additions and 11 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -35,8 +35,6 @@ Soon, there will also be the possibility to install easily via the Moodle Plugin
To use the plugin, just click on one of the recording buttons (either the microphone or the video camera), and a popup will appear with a big "Start Recording" button. When clicked, the browser will probably ask for permission to use the webcam/microphone.

![Recording buttons](https://user-images.githubusercontent.com/2160185/28581382-0cfd2078-7130-11e7-8181-0d545287a154.png)
*Or on older versions of Moodle:*
![Recording buttons](https://user-images.githubusercontent.com/2160185/28581438-31db5748-7130-11e7-96a4-75edf1677601.png)

After the recording starts, a timer will begin counting down, indicating how much time is left to record; when the timer hits 0, the recording will automatically stop (this will also happen if approaching the maximum upload size determined in the server settings).

@@ -73,7 +71,7 @@ The plugin can be configured during the initial install, and later by navigating
```
define([], function() {
```

Or so (for Adapter.js):

*Old code*
2 changes: 2 additions & 0 deletions RELEASENOTES
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
1.0-b4 (2017080103)
Bug: Fixed issue icons not shown properly in the Clear theme in Moodle 3.3
8 changes: 2 additions & 6 deletions lib.php
Original file line number Diff line number Diff line change
@@ -49,13 +49,9 @@ function atto_recordrtc_params_for_js($elementid, $options, $fpoptions) {
$audiobitrate = get_config('atto_recordrtc', 'audiobitrate');
$videobitrate = get_config('atto_recordrtc', 'videobitrate');
$timelimit = get_config('atto_recordrtc', 'timelimit');
$audiortcicon = 'ed/audiortc';
$videortcicon = 'ed/videortc';
$maxrecsize = ini_get('upload_max_filesize');
if ($moodleversion >= $moodle33) {
$audiortcicon = 'i/audiortc';
$videortcicon = 'i/videortc';
}
$audiortcicon = 'i/audiortc';
$videortcicon = 'i/videortc';
$params = array('contextid' => $context->id,
'sesskey' => $sesskey,
'recordrtcroot' => $CFG->wwwroot.'/lib/editor/atto/plugins/recordrtc/',
File renamed without changes
File renamed without changes
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
@@ -26,8 +26,8 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2017080102;
$plugin->version = 2017080103;
$plugin->requires = 2015051100;
$plugin->component = 'atto_recordrtc';
$plugin->maturity = MATURITY_BETA;
$plugin->release = '1.0-b3';
$plugin->release = '1.0-b4';

0 comments on commit a44191b

Please sign in to comment.