gatebox and shutterbox improvements: #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reporting gatebox position (if available) * fix for open/close mode in gatebox * foundation for reporting unified cover type across devices * save initialization state data as last updated * introduce enums that will allow to map to homeassistant cover types * simplify tilts
swistakm
force-pushed
the
shutterbox-and-gatebox-improvements
branch
from
c21b9cd to
65eaff2
Compare
|
Released in new library version (2.3.0) |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two improvements will be visible in home assistant once library is updated.
Examples:
Note that gatebox running in open/close mode does not have stop action. This is intended as secondary button action in this case is supposed to be wired to close output of actual gate. Also, for this mode close action incorrectly used
[p]rimarycommand instead of[s]econdary. In such a case the only way to close the gate was to use "stop" action.Extra improvements will allow to correctly map gateBox, gateController, and shutterBox control types / open-close modes to types of cover device classes used in home assistant. However, this will require submitting small PR on the home-assistant side.