Update "Fix inline list rendering in live preview (#2387)" #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reply2za
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6a6e025.
I had previously made a PR to "Fix inline list rendering in live preview". Although the PR does do this, after more thorough testing, I have realized that my merged change also slows down loading times of larger notes that have many inline properties. I strive to make fixes and improvements that will not incur any such negative consequences.
While I am looking into a better fix, I would like to revert my change in the meantime to prevent this from going into the next release.Edit
I have come across a solution that resolves displaying lists within live preview without any performance impact. I added the better fix to this branch.
Link to previous issues, for reference: #2385, #2281.