adding conditional url-encoding, fixing xml parameter extraction bug #2204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this bug: #2182
And also changes the way url-encoding is handled within lightfuzz. Now there will be default url-encoding for all outgoing probes, but submodules can opt-out, and we also do not enforce when any envelopes are present.
I also tweaked the regexes to allow for the extraction of parameters with spaces, which in light of the above changes, can now successfully be used without any issues.
Various tests had to be refined. Mostly because they weren't dynamic enough, I was hardcoding the existing URL-encoding into them when I should have them act more like a real server and decode before checking