Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding conditional url-encoding, fixing xml parameter extraction bug #2204

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

liquidsec
Copy link
Collaborator

This PR fixes this bug: #2182

And also changes the way url-encoding is handled within lightfuzz. Now there will be default url-encoding for all outgoing probes, but submodules can opt-out, and we also do not enforce when any envelopes are present.

I also tweaked the regexes to allow for the extraction of parameters with spaces, which in light of the above changes, can now successfully be used without any issues.

Various tests had to be refined. Mostly because they weren't dynamic enough, I was hardcoding the existing URL-encoding into them when I should have them act more like a real server and decode before checking

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (d1e8e38) to head (1ed52d0).
Report is 5 commits behind head on lightfuzz.

Files with missing lines Patch % Lines
...t/test_step_2/module_tests/test_module_excavate.py 96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           lightfuzz   #2204   +/-   ##
=========================================
+ Coverage         93%     93%   +1%     
=========================================
  Files            392     392           
  Lines          31780   31826   +46     
=========================================
+ Hits           29373   29421   +48     
+ Misses          2407    2405    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liquidsec liquidsec merged commit a250d04 into lightfuzz Jan 23, 2025
6 checks passed
@liquidsec liquidsec deleted the lightfuzz-conditional-encoding branch January 23, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants