Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lightfuzz serial submodule False Positives #2176

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

liquidsec
Copy link
Collaborator

Should begin to reduce false positives as described in #2170

Fully remediating these FPs will likely be an iterative process due to the nature of the detection algorithm.

Also changing behavior regarding original values, previously any parameter with an original value was ignored. Now, they will be checked, but only after surviving a validation function checking to see if they are valid 64 or hex (or raw php object). Added tests for all relevant functionality.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 91.07807% with 24 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (a250d04) to head (2b9a7bc).
Report is 12 commits behind head on lightfuzz.

Files with missing lines Patch % Lines
bbot/modules/lightfuzz_submodules/serial.py 76% 12 Missing ⚠️
.../test_step_2/module_tests/test_module_lightfuzz.py 95% 3 Missing ⚠️
bbot/modules/lightfuzz_submodules/crypto.py 84% 2 Missing ⚠️
bbot/core/engine.py 0% 1 Missing ⚠️
bbot/modules/baddns.py 0% 1 Missing ⚠️
bbot/modules/censys.py 0% 1 Missing ⚠️
bbot/modules/internal/unarchive.py 0% 1 Missing ⚠️
bbot/modules/lightfuzz.py 0% 1 Missing ⚠️
bbot/modules/lightfuzz_submodules/base.py 95% 1 Missing ⚠️
...t/test_step_2/module_tests/test_module_excavate.py 93% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           lightfuzz   #2176   +/-   ##
=========================================
- Coverage         93%     93%   -0%     
=========================================
  Files            392     392           
  Lines          31826   31923   +97     
=========================================
+ Hits           29420   29490   +70     
- Misses          2406    2433   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liquidsec liquidsec merged commit e80f402 into lightfuzz Jan 23, 2025
15 checks passed
@liquidsec liquidsec deleted the lightfuzz-deserialize-fp-fix branch January 23, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants