Fix www-authenticate #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As soon as I have a little time to test that this doesn't break things for other clients while fixing curl and Chrome, I'll merge it in. I should also write some unit tests for just this situation. Thanks for the code. I'll do my best to test and get it merged in the next few days. |
|
ok, no rush for me - at least it is tracked and others might notice in the meantime. Previously, I did not put much time into checking the standard, but I just did a quick check. Top of RFC 2617, section 1.2: "...comma-separated list of attribute-value pairs...." The grammar specifications do not show this comma, but the examples do. |
Added setup.py so pip install would be happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pull request for the issue I sent you an e-mail about. Curl and Chrome require that www-authenticate header have commas.