Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHRE-292: Update step name to not use dynamic value #358

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mimartin12
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Remove the unused value that is in the title of the step.

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@mimartin12 mimartin12 requested a review from a team as a code owner December 30, 2024 20:39
@mimartin12 mimartin12 enabled auto-merge (squash) December 30, 2024 20:39
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 239fc39b-b1c4-4967-883e-020c7c42bbea

No New Or Fixed Issues Found

@mimartin12 mimartin12 merged commit 964ffc2 into main Jan 2, 2025
5 checks passed
@mimartin12 mimartin12 deleted the BRE-292-update-step-name branch January 2, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants