Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15972] Delete fdroid/repo/categories.txt #132

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Jan 8, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15972

๐Ÿ“” Objective

Remove the "categories" entry in the F-Droid repo. This is done by deleting the unnecessary categories.txt file.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner January 8, 2025 16:56
@SaintPatrck SaintPatrck enabled auto-merge (squash) January 8, 2025 16:58
Copy link

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 73139cda-f9ed-44fd-8f53-dd2f1b586384

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck changed the title Delete fdroid/repo/categories.txt [PM-15972] Delete fdroid/repo/categories.txt Jan 8, 2025
@SaintPatrck SaintPatrck merged commit 7dacb7e into main Jan 8, 2025
6 checks passed
@SaintPatrck SaintPatrck deleted the delete-categories-file branch January 8, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants