-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17530] delete obsolete registration component #13181
Draft
alec-livefront
wants to merge
14
commits into
main
Choose a base branch
from
auth/pm-17530/delete-obsolete-registration-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[PM-17530] delete obsolete registration component #13181
alec-livefront
wants to merge
14
commits into
main
from
auth/pm-17530/delete-obsolete-registration-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13181 +/- ##
==========================================
- Coverage 35.50% 35.50% -0.01%
==========================================
Files 3007 3001 -6
Lines 90887 90459 -428
Branches 16906 16786 -120
==========================================
- Hits 32267 32114 -153
+ Misses 56118 55882 -236
+ Partials 2502 2463 -39 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17530?atlOrigin=eyJpIjoiMDBjYjYzM2FjZjBjNGY5ZGE3NWUyZDM4MTk1YTI3MGIiLCJwIjoiaiJ9
📔 Objective
Removes old registration components. Also includes changes from #12862
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes