Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-569] Optionally allow item content to wrap #13178

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Jan 31, 2025

🎟️ Tracking

CL-569

📔 Objective

This PR adds the option to allow bit item content to wrap instead of truncate.

📸 Screenshots

Check Storybook action for new text overflow wrap story.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (3b8b9c9) to head (e52f074).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
libs/components/src/item/item.stories.ts 0.00% 3 Missing ⚠️
libs/components/src/item/item-content.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13178      +/-   ##
==========================================
- Coverage   35.49%   35.49%   -0.01%     
==========================================
  Files        3007     3007              
  Lines       90887    90890       +3     
  Branches    16906    16906              
==========================================
  Hits        32260    32260              
- Misses      56125    56128       +3     
  Partials     2502     2502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details43ab0c54-a276-48f1-bc0a-9a572a5907be

Great job, no security vulnerabilities found in this Pull Request

@vleague2 vleague2 marked this pull request as ready for review January 31, 2025 17:20
@vleague2 vleague2 requested a review from a team as a code owner January 31, 2025 17:20
@vleague2 vleague2 requested review from willmartian and merissaacosta and removed request for willmartian January 31, 2025 17:20
Copy link
Contributor

@merissaacosta merissaacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab

@vleague2 vleague2 merged commit ca53ecc into main Jan 31, 2025
90 checks passed
@vleague2 vleague2 deleted the uif/cl-569/item-content-wrap branch January 31, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants