Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more bad imports #12935

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ignore more bad imports #12935

wants to merge 2 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 17, 2025

🎟️ Tracking

📔 Objective

Found more bad imports.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Logo
Checkmarx One – Scan Summary & Detailsc459287a-f067-4e3a-b377-09f35c53d3b0

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth files LGTM

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.32%. Comparing base (83802fc) to head (be1ca83).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12935   +/-   ##
=======================================
  Coverage   34.32%   34.32%           
=======================================
  Files        2976     2976           
  Lines       90529    90529           
  Branches    16954    16954           
=======================================
  Hits        31076    31076           
  Misses      56997    56997           
  Partials     2456     2456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mzieniukbw
mzieniukbw previously approved these changes Jan 17, 2025
@Hinton Hinton enabled auto-merge (squash) January 20, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants