Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n import of drawer component #12932

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix i18n import of drawer component #12932

merged 1 commit into from
Jan 17, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 17, 2025

๐Ÿ“” Objective

Resolves main being broken after merging #12831 due to a new component depending on I18nPipe.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner January 17, 2025 15:51
@Hinton Hinton requested a review from merissaacosta January 17, 2025 15:51
@Hinton Hinton enabled auto-merge (squash) January 17, 2025 15:57
@Hinton Hinton merged commit 83802fc into main Jan 17, 2025
74 checks passed
@Hinton Hinton deleted the cl-header-i18n branch January 17, 2025 16:01
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 466bcb10-70d1-420f-a961-661e2020dd67

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants