-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-16926] Fix KM bad imports #12807
base: main
Are you sure you want to change the base?
Conversation
@@ -7,7 +7,7 @@ export { BiometricsCommands } from "./biometrics/biometrics-commands"; | |||
export { BiometricsService } from "./biometrics/biometric.service"; | |||
export * from "./biometrics/biometric.state"; | |||
|
|||
export { KeyService } from "./abstractions/key.service"; | |||
export { KeyService, CipherDecryptionKeys } from "./abstractions/key.service"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to add CipherDecryptionKeys
for the test file libs/common/src/vault/services/cipher.service.spec.ts
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12807 +/- ##
=======================================
Coverage 34.32% 34.32%
=======================================
Files 2976 2976
Lines 90551 90551
Branches 16959 16959
=======================================
+ Hits 31079 31086 +7
+ Misses 57015 57008 -7
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auth changes good.
e3ddef6
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16926
📔 Objective
The purpose of this PR is to fix bad imports identified in #12744.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes