Fix incorrect BitBucket diffstat API usage. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where using the drone-tree-config plugin with BitBucket Cloud results in commits not triggering builds in Drone, showing "did not find a .drone.yml" error messages.
After debugging, I found that no files are ever listed when fetching a commit's changes, seemingly due to a confusion on the BitBucket diffstat 2.0 API usage. This incorrect usage does not cause any errors to be returned by the Bitbucket API, instead receiving back a successful but empty response.
Looking at the documentation, the following seems to be the source of the problem:
After the simple changes in this PR, I have got builds working successfully.