Skip to content

Commit

Permalink
Remove Alpine 3.16 from test matrix (#315)
Browse files Browse the repository at this point in the history
This removes our Alpine 3.16-based test image as it was heavily flaky (failing with timeouts
in about every other test run) and we have no idea how to fix it. On the other hand, we have
run ChromicPDF on Alpine 3.16 for years and it worked perfectly fine. Additionally, the
situation seems to have improved with more recent Chromiums a lot, so that the other test
images do not have timeout issues anymore. Alpine 3.16 is also quite old by now, so I conclude
we're ok to just drop it, in favor of having green test runs again some day.
  • Loading branch information
maltoe authored Jul 25, 2024
1 parent 8c21994 commit 9bebccf
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 43 deletions.
40 changes: 0 additions & 40 deletions .github/docker/Dockerfile_alpine-3-16-2

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/publish-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
packages: write
strategy:
matrix:
dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']
dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4']

steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
name: ${{ matrix.tag }}
strategy:
matrix:
tag: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']
tag: ['elixir-1-11', 'debian-buster', 'alpine-3-17-3', 'alpine-3-18-4']
env:
MIX_ENV: test
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ ChromicPDF is tested in the following configurations:
| ------ | ---------- | --------------- | --------------- | ----------- |
| 1.15.7 | 26.2 | Alpine 3.18 | 119.0.6045.159 | 10.02.0 |
| 1.14.5 | 25.3.1 | Alpine 3.17 | 112.0.5615.165 | 10.01.1 |
| 1.14.0 | 25.1 | Alpine 3.16 | 102.0.5005.182 | 9.56.1 |
| 1.14.0 | 25.1 | Debian Buster | 90.0.4430.212-1 | 9.27 |
| 1.11.4 | 22.3.4.26 | Debian Buster | 90.0.4430.212-1 | 9.27 |

Expand Down

0 comments on commit 9bebccf

Please sign in to comment.